Skip to content

Commit

Permalink
update min version of testthat and precommit config (#627)
Browse files Browse the repository at this point in the history
Similar with insightsengineering/teal.code#220,
failure in min_isolated pipeline:

https://github.com/insightsengineering/teal.slice/actions/runs/11537362432/job/32114685586#step:9:1346

### Summary:

* Update testthat minimum version due to usage of `testthat::it()` in
DESCRIPTION file:

https://github.com/insightsengineering/teal.slice/blob/main/tests/testthat/test-utils.R#L9

* Add `teal.code` to the pre-commit configuration to allow it to use the
development version when running. This is necessary because the
development version of `teal.data` requires the development version of
`teal.code` to run, and without this, the pre-commit will fail.
  • Loading branch information
donyunardi authored Nov 1, 2024
1 parent e07256a commit b732c15
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ repos:
- shinycssloaders
- shinyjs
- shinyWidgets
- insightsengineering/teal.code
- insightsengineering/teal.data
- insightsengineering/teal.logger
- insightsengineering/teal.widgets
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Suggests:
MultiAssayExperiment,
rmarkdown (>= 2.23),
SummarizedExperiment,
testthat (>= 3.1.5),
testthat (>= 3.1.8),
withr (>= 2.1.0)
VignetteBuilder:
knitr,
Expand Down

0 comments on commit b732c15

Please sign in to comment.