Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated #495

Merged
merged 1 commit into from
Dec 11, 2023
Merged

remove deprecated #495

merged 1 commit into from
Dec 11, 2023

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Dec 11, 2023

Remove deprecated methods

@gogonzo gogonzo added the core label Dec 11, 2023
@chlebowa chlebowa self-assigned this Dec 11, 2023
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R              8       0  100.00%
R/choices_labeled.R              49      14  71.43%   22, 33, 38, 48-53, 65, 69-73
R/count_labels.R                 98       0  100.00%
R/filter_panel_api.R             35       1  97.14%   100
R/FilteredData-utils.R           98      29  70.41%   16-19, 22-25, 46-51, 144, 166-175, 235-238
R/FilteredData.R                537     205  61.82%   146, 287, 481-490, 512, 533-574, 592-595, 611, 652-685, 700-702, 706-712, 738-766, 788-790, 794-796, 799-810, 814-823, 825-851, 892, 915-937
R/FilteredDataset-utils.R        18       1  94.44%   113
R/FilteredDataset.R             176      67  61.93%   45, 144, 186-192, 220-277, 317-319
R/FilteredDatasetDefault.R      121       9  92.56%   65, 127, 137, 141, 224-228
R/FilteredDatasetMAE.R          134      37  72.39%   23, 109-114, 153-158, 162-163, 183-205
R/FilterPanelAPI.R               10       0  100.00%
R/FilterState-utils.R           101       2  98.02%   262, 290
R/FilterState.R                 361      61  83.10%   88, 212, 230-234, 241-242, 256-257, 263-264, 312, 314, 316, 368, 412, 644, 687-712, 723-742, 777-783, 792-798
R/FilterStateChoices.R          338     106  68.64%   302-305, 317, 360, 384-391, 395-412, 441, 456-467, 479-487, 491-520, 541-544, 547-550, 561-582, 595-596, 606
R/FilterStateDate.R             212     129  39.15%   219, 272-430
R/FilterStateDatettime.R        307     199  35.18%   256, 309-541
R/FilterStateEmpty.R             53      31  41.51%   82, 92-97, 111, 125-166
R/FilterStateExpr.R              75      62  17.33%   138-262
R/FilterStateLogical.R          196     144  26.53%   127, 150, 210, 213-399
R/FilterStateRange.R            410     105  74.39%   254, 378, 506-510, 513-523, 526, 538-544, 555-567, 571-581, 585-587, 601-628, 643, 646, 661-678, 713-718, 728-730
R/FilterStates-utils.R           70       9  87.14%   102, 121, 179-185, 207, 234
R/FilterStates.R                364      30  91.76%   76-80, 189, 320-329, 417-420, 463, 548-552, 597, 718-721
R/FilterStatesDF.R                5       0  100.00%
R/FilterStatesMAE.R              10       1  90.00%   39
R/FilterStatesMatrix.R            3       0  100.00%
R/FilterStatesSE.R              211     157  25.59%   34, 69-71, 81-83, 107-114, 122-129, 152-300
R/include_css_js.R                5       5  0.00%    12-16
R/teal_slice.R                  107       4  96.26%   135, 189-190, 201
R/teal_slices.R                  83       5  93.98%   144-149
R/test_utils.R                   21       0  100.00%
R/utils.R                        49       2  95.92%   101-102
R/variable_types.R               48      33  31.25%   41-46, 56, 69-104
R/zzz.R                          16      16  0.00%    3-47
TOTAL                          4329    1464  66.18%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/FilteredData.R       -9      -9  +1.02%
TOTAL                  -9      -9  +0.14%

Results for commit: 5af82ec

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

    1 files    28 suites   22s ⏱️
356 tests 356 ✔️ 0 💤 0
814 runs  814 ✔️ 0 💤 0

Results for commit 5af82ec.

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gogonzo gogonzo merged commit bef1e60 into main Dec 11, 2023
24 checks passed
@gogonzo gogonzo deleted the remove_deprecated@main branch December 11, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants