Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

507 reevaluate variable_types #508

Merged
merged 8 commits into from
Jan 30, 2024
Merged

507 reevaluate variable_types #508

merged 8 commits into from
Jan 30, 2024

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Jan 3, 2024 •
edited
Loading

Closes #507

Replaced variable_types function family with single function.
The new function returns a named vector so no need to use setNames in its caller.

@chlebowa chlebowa added the core label Jan 3, 2024
@chlebowa chlebowa requested a review from gogonzo January 3, 2024 16:26
@gogonzo gogonzo self-assigned this Jan 8, 2024
gogonzo
gogonzo reviewed Jan 8, 2024
View reviewed changes
R/variable_types.R Outdated Show resolved Hide resolved
@gogonzo
Copy link
Contributor

gogonzo commented Jan 8, 2024

I think we can include this before release.

gogonzo
gogonzo reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module add generates proper choices icons (according to type) in multiple apps I've tested. I don't see any obstacles to merge it

@pawelru
Copy link
Contributor

pawelru commented Jan 8, 2024

Watch out here! TMG is using this private function: https://github.com/insightsengineering/teal.modules.general/blob/38ff2b0e06afa226d2507bc0100801bd7a663a99/R/tm_variable_browser.R#L1192

@chlebowa
Copy link
Contributor Author

chlebowa commented Jan 8, 2024

Thanks or the warning @pawelru. The setNames is redundant and in no way disruptive. I will look find other uses of this function in other packages and test them.

@chlebowa chlebowa mentioned this pull request Jan 9, 2024
Merged
chlebowa added a commit to insightsengineering/teal.modules.general that referenced this pull request Jan 16, 2024
@chlebowa @averissimo
507 reevaluate variable_types (#622)
77ad143 
companion to insightsengineering/teal.slice#508

---------

Signed-off-by: Aleksander Chlebowski <[email protected]>
Co-authored-by: André Veríssimo <[email protected]>
@chlebowa chlebowa changed the base branch from main to post-pre-release-cleanup-cleanup@main January 30, 2024 15:40
@chlebowa chlebowa removed the Blocked label Jan 30, 2024
@chlebowa chlebowa marked this pull request as ready for review January 30, 2024 15:47
@chlebowa chlebowa merged commit 82c8406 into post-pre-release-cleanup-cleanup@main Jan 30, 2024
@chlebowa chlebowa deleted the 507_variable_types@main branch January 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo left review comments

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reevaluate variable_types function
3 participants
@chlebowa @gogonzo @pawelru