Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI changes on upgrade to bslib and Bootstrap 5 #619

Closed
wants to merge 9 commits into from
Closed

UI changes on upgrade to bslib and Bootstrap 5 #619

wants to merge 9 commits into from

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Sep 24, 2024

Draft PR, will be broken into smaller PRs soon

@vedhav vedhav marked this pull request as draft September 24, 2024 07:12
@gogonzo gogonzo added the core label Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Unit Tests Summary

  1 files   29 suites   23s ⏱️
360 tests 360 ✅ 0 💤 0 ❌
826 runs  826 ✅ 0 💤 0 ❌

Results for commit 1bce69e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R                7       0  100.00%
R/choices_labeled.R                49      14  71.43%   25, 36, 41, 51-56, 68, 72-76
R/count_labels.R                  102       0  100.00%
R/filter_panel_api.R               27       1  96.30%   132
R/FilteredData-utils.R             68      25  63.24%   21-24, 27-30, 52-57, 153, 175-184
R/FilteredData.R                  555     202  63.60%   110, 184, 326, 398, 503-511, 534, 553-612, 632-635, 675, 712, 733-765, 788-790, 793-807, 811-821, 824-867, 924, 936-958
R/FilteredDataset-utils.R          23       1  95.65%   125
R/FilteredDataset.R               231      93  59.74%   48, 147, 179, 206-297, 374
R/FilteredDatasetDataframe.R      120       8  93.33%   87, 148, 158, 233-237
R/FilteredDatasetDefault.R         18       4  77.78%   104-117
R/FilteredDatasetMAE.R            133      37  72.18%   56, 117-122, 159-164, 168-169, 187-209
R/FilterPanelAPI.R                 10       0  100.00%
R/FilterState-utils.R             101       2  98.02%   264, 294
R/FilterState.R                   363      61  83.20%   89, 213, 231-235, 242-243, 257-258, 264-265, 321, 323, 325, 377, 420, 641, 684-707, 717-736, 771-777, 786-792
R/FilterStateChoices.R            352     109  69.03%   301, 368-375, 379-396, 423-426, 439-450, 462-470, 474-503, 523-526, 529-532, 542-567, 578, 583, 594
R/FilterStateDate.R               213     127  40.38%   230, 282-437
R/FilterStateDatettime.R          307     197  35.83%   266, 318-547
R/FilterStateEmpty.R               53      31  41.51%   89, 99-104, 117, 129-169
R/FilterStateExpr.R                83      68  18.07%   167-280
R/FilterStateLogical.R            194     142  26.80%   136, 158, 218, 222-404
R/FilterStateRange.R              410     104  74.63%   262, 384, 517-521, 524-534, 537, 548-554, 565-577, 581-591, 595-597, 610-636, 651, 654, 668-685, 720-725, 735-737
R/FilterStates-utils.R             70       7  90.00%   108, 127, 188-194
R/FilterStates.R                  361      31  91.41%   76-80, 187, 309-318, 403-406, 449, 487, 550-554, 599, 719-722
R/FilterStatesDF.R                  5       0  100.00%
R/FilterStatesMAE.R                10       1  90.00%   40
R/FilterStatesMatrix.R              3       0  100.00%
R/FilterStatesSE.R                216      62  71.30%   36, 71-73, 83-85, 108-115, 123-130, 206, 231, 250-268, 276-294, 302
R/include_css_js.R                  5       5  0.00%    12-16
R/teal_slice.R                    107       4  96.26%   131, 195-196, 206
R/teal_slices.R                    84       5  94.05%   150-155
R/test_utils.R                     21       0  100.00%
R/utils.R                          20       0  100.00%
R/variable_types.R                 15       1  93.33%   48
R/zzz.R                            17      17  0.00%    3-47
TOTAL                            4353    1359  68.78%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/FilteredData.R         +15     +16  -1.95%
R/FilteredDataset.R       -1     +21  -9.23%
TOTAL                    +14     +37  -0.75%

Results for commit: 1bce69e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

vedhav
vedhav commented Sep 26, 2024
View reviewed changes
R/FilteredDataset.R
Comment on lines 230 to +240
tags$i(
id = ns("add_filter_icon"),
class = "fa fa-plus",
title = "fold/expand transform panel",
onclick = sprintf(
"togglePanelItems(this, '%s', 'fa-plus', 'fa-minus');",
ns("add_panel")
"togglePanelItems(this, '%s', 'fa-plus', 'fa-minus');
if ($(this).hasClass('fa-minus')) {
$('#%s .accordion-button.collapsed').click();
}",
ns("add_panel"),
ns("dataset_filter_accordian")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gogonzo I'm using the accordion open/close in cases where I can trigger using R. Here, it is not important for this icon to create shiny binding so simply clicking the accordion button seemed like an acceptable solution.

@vedhav
Copy link
Contributor Author

vedhav commented Oct 25, 2024

Closing the PR. This will be split into different PRs

@vedhav vedhav closed this Oct 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedhav @gogonzo