-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #480 add invisible(x) to print.teal_slice
#636
issue #480 add invisible(x) to print.teal_slice
#636
Conversation
…(My first commit; want to be sure everything is OK)
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Many thanks for your contribution!
This is a great start.
Could you please update print.teal_slices
with a similar change?
Could you add tests for these changes on the corresponding test-teal_slice.R
and test-teal_slices.R
? Then we will be sure this remains working and fits the documentation.
Test could be something like teal_slice <- print(teal_slice(...))
and checking that the output is the same as the input.
@llrs-roche Thanks for guidance! I'm coming from So comments, suggestions .... needed and very welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, each team have their preferences and methods. I'm sure I would also learn a lot if I contributed or used {admiral}.
You are on a great start with {teal}! I left two suggestions to make a test match the context and purpose of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now! Apologies for not raising this before, but could you add a NEWs entry explaining this? If not I'll do it myself before merging this.
… return object invisibily.
@llrs-roche |
Pull Request
Fixes #480
(First commit: want to be sure all is OK - Thx.)