Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP remove teal.code #242

Merged
merged 8 commits into from
Jan 30, 2025
Merged

WIP remove teal.code #242

merged 8 commits into from
Jan 30, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 28, 2025

Fixes #241 #193

TODO

  • verify if teal.code can be removed from .github/worfklows
  • verify if teal.code can be removed from staged_dependencies.yaml
staged dependencies code
library(staged.dependencies)
x <- dependency_table(project = ".")
install_deps(x, verbose = 1)

@m7pr m7pr added the core label Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Unit Tests Summary

  1 files   24 suites   6s ⏱️
193 tests 193 ✅ 0 💤 0 ❌
679 runs  679 ✅ 0 💤 0 ❌

Results for commit a78a6b9.

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 28, 2025

R CMD CHECKS are failing becuase dependencies can't be resolved.
IMHO teal.data PR needs to be merged insightsengineering/teal.data#364 so that dependencies conflicts are resolved in here

@m7pr m7pr added the blocked label Jan 28, 2025
@vedhav
Copy link
Contributor

vedhav commented Jan 29, 2025

@m7pr can we also remove the insightsengineering/teal.code from the lookup-refs of all the workflows? I think that will fix the CI

@vedhav vedhav self-assigned this Jan 29, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

@vedhav this was on the TODO list, but I'm not sure if we can remove it from lookup-refs, but just removed to test if that allows pipelines to pass

m7pr added 2 commits January 29, 2025 11:06
Signed-off-by: Marcin <[email protected]>
Signed-off-by: Marcin <[email protected]>
@m7pr m7pr removed the blocked label Jan 29, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

It fixed R CMD Checks.

@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

Rerunning once more teal.data was vbumped on main
https://github.com/insightsengineering/teal.transform/actions/runs/13029875087

@m7pr
Copy link
Contributor Author

m7pr commented Jan 29, 2025

Hey @vedhav and @llrs-roche - R CMD CHECKs and staged.dependencies installation passes with green colours.
Scheduled job does not pass, but it has a cache hickup today and claims it doesn't seen teal.data that was released yesterday.

Let's merge this one, and let's see if Scheduled job goes smooth over the night.

Copy link

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduled tests fails, other than that the rest looks good: image. Leaving the approval decision to @vedhav

@m7pr m7pr enabled auto-merge (squash) January 30, 2025 11:34
m7pr added a commit to insightsengineering/teal.code that referenced this pull request Jan 30, 2025
@m7pr m7pr merged commit 464fe2e into main Jan 30, 2025
37 checks passed
@m7pr m7pr deleted the remove_tealcode@main branch January 30, 2025 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: Why do we need teal.code in teal.transform
3 participants