Add teal app modifiers and deprecate init args

[vedhav]

Closes #1310 and #1143

Changes

• The title, header, and footer are soft deprecated in favor of using add_title, add_header, add_footer, and add_landing_popup
• Adds a new add_custom_server modifier to add custom server logic to the main shiny app.
• Reverts the usage of landing_popup_module to the previous way by passing it inside the modules
• Bumps R version to 4.1 to start using native pipe |>

Example app with the new app modifiers.

devtools::load_all("teal")

app <- init(
  data = teal_data(IRIS = iris, MTCARS = mtcars),
  modules = modules(
    example_module("Module 1"),
    example_module("Module 2")
  ),
  filter = teal_slices(
    teal_slice(dataname = "IRIS", varname = "Species", selected = "setosa")
  )
) |>
  modify_title("Custom title") |>
  modify_header(
    tags$div(
      h3("Header with a button that can be observed!"),
      actionButton("notify", "Show notification")
    )
  ) |>
  modify_footer("Custom footer") |>
   add_landing_popup(
      content = "Popup content",
      buttons = modalButton("Proceed")
   ) |>
  add_custom_server(function(input, output, session) {
    observeEvent(input$notify, {
      showNotification("Yes, the button works!")
    })
  })

shinyApp(app$ui, app$server)

[github-actions]

Unit Tests Summary

  1 files   28 suites   10m 39s ⏱️
276 tests 272 ✅ 4 💤 0 ❌
538 runs  534 ✅ 4 💤 0 ❌

Results for commit 62e836f.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
module_session_info	👶		$+17.15$	$+3$	$0$	$0$	$0$
module_teal	💚	$156.79$	$-25.92$	$-3$	$0$	$0$	$0$
shinytest2-filter_panel	💚	$43.46$	$-1.42$	$0$	$0$	$0$	$0$
shinytest2-landing_popup	💔	$45.44$	$+1.61$	$0$	$0$	$0$	$0$
shinytest2-module_bookmark_manager	💔	$36.06$	$+1.01$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
module_session_info	👶		$+17.14$	creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended
module_session_info	👶		$+0.02$	creation_process_is_not_invoked_for_teal.lockfile.mode_disabled_
module_teal	💚	$4.33$	$-1.12$	clicking_reset_button_restores_initial_filters_state_when_module_specific
module_teal	💀	$17.80$	$-17.80$	creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended
module_teal	💀	$0.07$	$-0.07$	creation_process_is_not_invoked_for_teal.lockfile.mode_disabled_

Results for commit 24910e0

♻️ This comment has been updated with latest results.

[gogonzo]

Some room for improvement

[gogonzo]

ui_teal shouldn't have header, footer, title arguments. Deprecation in init only is a half-measure. Please use add_header and add_title in teal::init body instead of passing arguments to ui_teal.

Edit: Same applies to module_teal_with_splash

[gogonzo]

Thanks 👍

[pawelru]

https://github.com/insightsengineering/teal/pull/1440/files#r1920393327
same here

[vedhav]

Sure

[pawelru]

https://github.com/insightsengineering/teal/pull/1440/files#r1920393327
same here