Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error #1469

Merged
merged 3 commits into from
Jan 30, 2025
Merged

fix error #1469

merged 3 commits into from
Jan 30, 2025

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Jan 29, 2025

closes insightsengineering/teal.reporter#302
TealReporterCard inherits from ReporterCard, when loading from file TealReporterCard$dispatch_block(block_class) is triggered. Because TealReporterCard is in teal namespace, TextBlock is failing as TextBlock is a teal.reporter (private) object.

I hope code fix is self explanatory.

@gogonzo gogonzo added bug Something isn't working core labels Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Tests Summary

  1 files   28 suites   10m 37s ⏱️
278 tests 274 ✅ 4 💤 0 ❌
540 runs  536 ✅ 4 💤 0 ❌

Results for commit 956bc7b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $130.43$ $-1.06$ $0$ $0$ $0$ $0$
shinytest2-teal_slices 💚 $62.30$ $-1.41$ $0$ $0$ $0$ $0$

Results for commit f444093

♻️ This comment has been updated with latest results.

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm I see an error on the bottom right corner when uploading the report (even if generated with this branch) on main branch:

Loading reporter error!
Please contact app developer

When I upload the report on this branch I do not longer see this error.

I wonder if there's a way to test this. This function seems important and that it had slipped through checks.

R/teal_reporter.R Show resolved Hide resolved
@llrs-roche llrs-roche self-assigned this Jan 29, 2025
@gogonzo gogonzo enabled auto-merge (squash) January 30, 2025 12:16
@gogonzo gogonzo merged commit 44b2b9c into main Jan 30, 2025
25 checks passed
@gogonzo gogonzo deleted the 302_reporter_upload branch January 30, 2025 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Upload of the reporter fails
2 participants