Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of scda with random.cdisc.data #176

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #175

@edelarua edelarua added the sme label May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@edelarua
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@edelarua edelarua changed the title Repalce usage of scda with random.cdisc.data Replace usage of scda with random.cdisc.data May 13, 2024
Copy link
Contributor

Unit Tests Summary

  1 files   11 suites   16s ⏱️
110 tests  81 ✅ 29 💤 0 ❌
219 runs  178 ✅ 41 💤 0 ❌

Results for commit 25f02e1.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @edelarua , one minor spell check issue is blocking this

@edelarua
Copy link
Contributor Author

lgtm! thanks @edelarua , one minor spell check issue is blocking this

@shajoezhu we should be able to merge with the failing check since the spell check issue is falsely reported.

I believe this is related to the unicode processing issue filed here insightsengineering/r.pkg.template#227 (caused by r-lib/styler#1199) and can be ignored for now.

@shajoezhu shajoezhu merged commit f7fb3f5 into main May 14, 2024
24 of 25 checks passed
@shajoezhu shajoezhu deleted the 175_scda_to_rcd@main branch May 14, 2024 23:06
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usage of scda with random.cdisc.data
2 participants