Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pct bug in tabulate_rsp_subgroups when risk difference column is added #1387

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #1386

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Tests Summary

    1 files     84 suites   1m 24s ⏱️
  876 tests   867 ✅   9 💤 0 ❌
1 882 runs  1 185 ✅ 697 💤 0 ❌

Results for commit bdba6c0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
analyze_vars_in_cols 💔 $2.34$ $+3.46$ $+17$ $-7$ $0$ $0$
count_occurrences 💔 $0.73$ $+1.71$ $+10$ $-8$ $0$ $0$
count_occurrences_by_grade 💔 $1.73$ $+1.13$ $+16$ $-17$ $0$ $0$
summarize_coxreg 💔 $3.19$ $+3.21$ $+13$ $-13$ $0$ $0$
summarize_num_patients 💔 $1.04$ $+1.28$ $+18$ $-16$ $0$ $0$
survival_duration_subgroups 💔 $4.97$ $+1.03$ $+7$ $-14$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
analyze_vars_in_cols 💔 $0.47$ $+1.55$ summarize_works_with_nested_analyze
summarize_coxreg 💔 $0.48$ $+1.42$ summarize_coxreg_adds_the_multivariate_Cox_regression_layer_to_rtables

Results for commit 379cef5

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Emily for the swift fix

@edelarua edelarua merged commit 12ab34e into main Jan 31, 2025
29 checks passed
@edelarua edelarua deleted the 1386_riskdiff_pct_bug branch January 31, 2025 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
@shajoezhu
Copy link
Contributor

hi @edelarua , could you add two test cases for this in scda.test please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants