Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adapt test to updated com.github.mwiede:jsch #293

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

gschafra
Copy link

@gschafra gschafra commented Nov 7, 2022

This fixes the bug #292

Steps to verify the fix

  1. SSH connect to a SSH server running OpenSSH 7.8+ with a newer key (e.g. ed25519)

Backward compatibility

@elijahfhopp
Copy link
Contributor

Hey, sorry about #294 . I really didn't see this before I made my changes. I think they are different enough to warrant a different PR. I did copy your comment/code for the user agent auth code bit. It was much better then I had. Thanks!

@gschafra
Copy link
Author

Hey @mrzeusthecoder! No Problem, quite the opposite, I'm really relieved that some one has taken care of this, even if it's in another PR, because I'm I simply lack deeper experience in Java/Groovy/Gradle/Maven. Because of this, I've seen this PR as a more or less good starting point for someone more experience to follow up on... as you did. So, thanks you. So do you think I can close my PR in favour of yours? Or are there still such significant differences which would justify to keep this PR?

@elijahfhopp
Copy link
Contributor

@gschafra Ok, good to hear. Never know how people might take that. I would say keep it open if only for the CI changes you made. Depending on how my PR goes, I would totally be willing to get that back up and running. I don't exactly know the changes you made, but they seemed somewhat significant.

Honestly, just do what you'd like. It doesn't seem like this repo is active enough to have any super strict contribution guidelines, 😊 .

Günter Schafranek added 4 commits February 27, 2023 23:19
# Conflicts:
#	.circleci/config.yml
#	build.gradle
#	cli/build.gradle
#	core/build.gradle
#	core/src/main/groovy/org/hidetake/groovy/ssh/connection/UserAuthentication.groovy
#	gradle/wrapper/gradle-wrapper.properties
#	os-integration-test/build.gradle
#	server-integration-test/build.gradle
@gschafra gschafra changed the title chore(dependencies): Updated to com.github.mwiede:jsch test: Adapt test to updated com.github.mwiede:jsch Mar 12, 2023
@gschafra gschafra marked this pull request as draft October 26, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants