-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Adapt test to updated com.github.mwiede:jsch #293
base: master
Are you sure you want to change the base?
Conversation
- ... due to https://stackoverflow.com/questions/72743823/public-key-authentication-fails-with-jsch-but-work-with-openssh-with-the-same-ke - ... and Java 11 - Minor dependency updates
- Adapted unit test
- Using up-to-date sshd docker image within a remote docker instance
Hey, sorry about #294 . I really didn't see this before I made my changes. I think they are different enough to warrant a different PR. I did copy your comment/code for the user agent auth code bit. It was much better then I had. Thanks! |
Hey @mrzeusthecoder! No Problem, quite the opposite, I'm really relieved that some one has taken care of this, even if it's in another PR, because I'm I simply lack deeper experience in Java/Groovy/Gradle/Maven. Because of this, I've seen this PR as a more or less good starting point for someone more experience to follow up on... as you did. So, thanks you. So do you think I can close my PR in favour of yours? Or are there still such significant differences which would justify to keep this PR? |
@gschafra Ok, good to hear. Never know how people might take that. I would say keep it open if only for the CI changes you made. Depending on how my PR goes, I would totally be willing to get that back up and running. I don't exactly know the changes you made, but they seemed somewhat significant. Honestly, just do what you'd like. It doesn't seem like this repo is active enough to have any super strict contribution guidelines, 😊 . |
# Conflicts: # .circleci/config.yml # build.gradle # cli/build.gradle # core/build.gradle # core/src/main/groovy/org/hidetake/groovy/ssh/connection/UserAuthentication.groovy # gradle/wrapper/gradle-wrapper.properties # os-integration-test/build.gradle # server-integration-test/build.gradle
jcenter()
repo in favour ofmavenCentral()
This fixes the bug #292
Steps to verify the fix
Backward compatibility