Update canonize to fix aarch64 bugs #801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vihang Mehta <[email protected]>
vihangm
force-pushed
the
vihang/memory
branch
from
2f1d365 to
d4bb873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I built NEO for ARM, it would segfault when trying to write to usm_host
mem. I tracked down the issue to canonize. Arm64 adresses don't expect the
unused high bits to be set to the same value at the most significant used bits.
Instead they are supposed to be set to 0 for userspace addresses.
See similar changes for gmmlib intel/gmmlib#126