Removing C++ code from the C header file kv.h #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When included in C code, kv.h causes various compiler errors as a result of including a C++ header file and using namespace and class names that won't compile with a C compiler. This patch uses a similar approach to another one that fixed the same issue in `iga.h`, as well as removes the function `kv_get_swsb_info` if the compiler is not C++. This should enable C++ code to continue using the header as if nothing happened, while also allowing C code to use the header without errors. Signed-off-by: Ben Olson <[email protected]>
|
CI errors seem unrelated to this patch; they're both: |
|
Please rebase your branch, it was expected that issue was fixed at ac5bbd1. |
Sure, done! |
|
Looks like the new failures are unrelated too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When included in C code, kv.h causes various compiler errors as a result of including a C++ header file and using namespace and class names that won't compile with a C compiler. This patch uses a similar approach to another one that fixed the same issue in
iga.h, as well as removes the functionkv_get_swsb_infoif the compiler is not C++.This should enable C++ code to continue using the header as if nothing happened, while also allowing C code to use the header without errors.
This fixes #354.