Skip to content
This repository has been archived by the owner on Jan 31, 2025. It is now read-only.

fix exporting buffers with 3 planes and VA_EXPORT_SURFACE_SEPARATE_LAYERS #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelolbrich
Copy link
Contributor

To get the plane offset, y_cb_offset or y_cr_offset must be multiplied with
the pitch for the 'Y' plane. See for example i965_DeriveImage().

Without this, exporting formats with 3 planes where cb_cr_pitch == width/2
is broken, because the offset of the third plane is calculated incorrectly.

…YERS

To get the plane offset, y_cb_offset or y_cr_offset must be multiplied with
the pitch for the 'Y' plane. See for example i965_DeriveImage().

Without this, exporting formats with 3 planes where cb_cr_pitch == width/2
is broken, because the offset of the third plane is calculated incorrectly.
@rmader
Copy link

rmader commented Mar 16, 2024

Just wanted to drop that I've been hitting this as well. I've worked around it with a dirty Gstreamer patch which usually gives the right results, but not always. Would be nice to still see this land!

@rmader
Copy link

rmader commented Mar 17, 2024

P.S.: I verified that this MR fixes playback with Gstreamer 1.24 vampeg2dec on my Thinkpad T400 (GM45/P8400) with the following samples:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants