Revert cleaning cache changes on Windows #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
…ckend-for-triton into amyachev/revert-cache-changes
anmyachev
force-pushed
the
amyachev/revert-cache-changes
branch
from
2500f9e to
5f64732
Compare
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
changed the title
pbchekin
approved these changes
Jan 24, 2025
…-triton into amyachev/revert-cache-changes
Signed-off-by: Anatoly Myachev <[email protected]>
gshimansky
reviewed
Jan 25, 2025
| if os.name == "nt": | ||
| os.remove(temp_path) | ||
| else: | ||
| raise |
There was a problem hiding this comment.
This change was necessary if multiple processes compile the same kernel and try to put files (not only .pyd) into the same cache directory. It happens when you run tests with xdist and all workers use the same triton cache directory. A user program might behave in the same way too.
There was a problem hiding this comment.
You are right, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With unloaded DLL libraries, these changes are no longer necessary. However, two tests that hold a reference to the compiled kernel need to be adjusted - manually clear the cache (inside
JITFunctionobject).CI:
Blocked on #3251
Extra refs: