Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix post-commit failure for OCL_interop_test.cpp on fpga #16930

Open
wants to merge 84 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Fix post-commit failure for OCL_interop_test.cpp on fpga #16930

wants to merge 84 commits into from

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Feb 7, 2025 •
edited
Loading

Fix post-commit failure for OCL_interop_test.cpp on fpga(See issue at the end of this description).
It seems like the issue is due to the OpenCL emulator for fpga not supporting the clCreateProgramWithIL function and a way to circumvent this seems to be to AOT compile for fpga using -fsycl-targets=spir64_fpga and use clCreateProgramWithBinary instead.
Closes: #16914

lbushi25 and others added 30 commits January 14, 2025 13:23
@lbushi25
Implement backend content extension
464174d
@lbushi25
Merge branch 'device_image_backend_content' of https://github.com/lbu…
217270c 
…shi25/llvm into device_image_backend_content
@lbushi25
Add tests for extension
776a3ed
@lbushi25
Merge branch 'intel:sycl' into device_image_backend_content
3080741
@lbushi25
Change extension spec status section
12bdf3f
@lbushi25
Merge branch 'device_image_backend_content' of https://github.com/lbu…
a4f6372 
…shi25/llvm into device_image_backend_content
@lbushi25
Add more tests and fix ABI related failures
c15a31a
@lbushi25
Add checks for span feature
0ba58c7
@lbushi25
Refactoring
50018cb
@lbushi25
More refactoring
b20f042
@lbushi25
Formatting
2c7b110
@lbushi25
Merge branch 'intel:sycl' into device_image_backend_content
b884eec
@lbushi25
Add windows symbols
36f4095
@lbushi25
Add check for std::span feature
5d4a6bf
@lbushi25
Add comments explaining limitations of free function kernel usage
273f6df
@lbushi25
Add asserts for extra safety
192cf75
@lbushi25
Define feature macro for device image backend content
5d7d500
@lbushi25
Improve testing logic
5050a3c
@lbushi25
Make comments more helpful
ab765f9
@lbushi25
Enhance tests
e8be859
@lbushi25
Resolve merge
fa68a24
@lbushi25
Remove rogue binary file
74c0772
@lbushi25
Improve L0_interop_test.cpp to avoid false positives
78e7ae6
@lbushi25 @Pennycook
Use __has_include to guard the inclusion of <span>
b2594e8 
Co-authored-by: John Pennycook <[email protected]>
@lbushi25
Update basic_test.cpp
5b88761
@lbushi25
Apply feedback
ccdd15c
@lbushi25
Merge branch 'sycl' into device_image_backend_content
e4914b8
@lbushi25
Update sycl_symbols_linux.dump
21f4a9b
@lbushi25
Update sycl_symbols_linux.dump
91853e0
@lbushi25
Add windows symbols
70c168a
@lbushi25 lbushi25 changed the title [SYCL] Fix post-commit failure for OCL_interop_test.cpp for fpga [SYCL] Fix post-commit failure for OCL_interop_test.cpp on fpga Feb 7, 2025
@lbushi25 lbushi25 marked this pull request as ready for review February 10, 2025 05:01
@lbushi25 lbushi25 requested a review from a team as a code owner February 10, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeviceImageBackendContent::OCL_interop_test.cpp failing on post-commit opencl:fpga
1 participant
@lbushi25