[NFCI][SYCL] Eliminate sycl/builtins_utils_*.hpp
#16931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Split the helper they used to provide between the builtins implementation and `sycl/detail/type_traits/vec_marray_traits.hpp`.
aelovikov-intel
force-pushed
the
remove-builtin-utils
branch
from
09b4d7d to
a7bf1ca
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Feb 8, 2025
Comment on lines
+113
to
+128
| template <typename NewElemT, typename T, typename = void> | ||
| struct change_elements { | ||
| using type = NewElemT; | ||
| }; | ||
| template <typename NewElemT, typename T> | ||
| struct change_elements<NewElemT, T, std::enable_if_t<is_marray_v<T>>> { | ||
| using type = | ||
| marray<typename change_elements<NewElemT, typename T::value_type>::type, | ||
| T::size()>; | ||
| }; | ||
| template <typename NewElemT, typename T> | ||
| struct change_elements<NewElemT, T, std::enable_if_t<is_vec_or_swizzle_v<T>>> { | ||
| using type = | ||
| vec<typename change_elements<NewElemT, typename T::element_type>::type, | ||
| T::size()>; | ||
| }; |
There was a problem hiding this comment.
This isn't just copy-paste, I'm using SFINAE instead of plain partial specialization. Main reason is to avoid relying on swizzle's implementation outside vec_marray_traits.hpp and I didn't think that this utility would fit there.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the helpers they used to provide between the builtins implementation and
sycl/detail/type_traits/vec_marray_traits.hpp.