Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][SYCL] Minor refactoring in sycl::vec #16934

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[NFC][SYCL] Minor refactoring in sycl::vec #16934

wants to merge 1 commit into from
+80 −65

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner February 8, 2025 00:33
@aelovikov-intel
Copy link
Contributor Author

Next change would be 63b9789, and the longer goal is something like sycl...aelovikov-intel:llvm:wip-vec

steffenlarsen
steffenlarsen approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but could you please add a description to the PR? The title doesn't explain the reason for the refactoring very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@KseniyaTikhomirova KseniyaTikhomirova Awaiting requested review from KseniyaTikhomirova KseniyaTikhomirova is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @uditagarwal97 @steffenlarsen