Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: WEBDEV-6730 fix flaky tests - fixmes #40

Closed
wants to merge 63 commits into from

Conversation

dualcnhq
Copy link
Collaborator

@dualcnhq dualcnhq commented Apr 18, 2024

This branch contains tests with .fixme() annotations

@dualcnhq dualcnhq changed the title Webdev 6730 fix flaky tests WEBDEV-6730 fix flaky tests Apr 18, 2024
run-tests.sh Outdated Show resolved Hide resolved
.env.sample Show resolved Hide resolved
.env.sample Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@iisa iisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think these tests are passing - are we skipping them?
i am not comfortable in merging this as there are many holes still with the tests, many of them are not being run, using fixme to skip...
q: what happened to smaller PRs? we should talk about approach,

run: npx playwright install --with-deps

- name: Run about tests
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: do you need the always?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always can be removed, it's just added so the next step will still run even if the previous step has failed

- name: Install Playwright Browsers
run: npx playwright install --with-deps
# - name: Run tests in Webkit browser
# run: npm run test:webkit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the difference between this and the new worflow above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new workflow will run the tests by category with specific order... while the other one will run the tests either by browser or all tests without order

@@ -0,0 +1,9 @@
# This is a basic workflow that is manually triggered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: why do we need a manual trigger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will help on debugging tests that runs in pipeline vs locally

PATRON_EMAIL: ${{ secrets.PATRON_EMAIL }}
PATRON_PASSWORD: ${{ secrets.PATRON_PASSWORD }}
run: |
${{ github.event.inputs.input_command }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q? asking again if we need this manuall lever?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this one, we want to have a way to run specific tests in pipeline and compare it to the one that was ran locally

},
privUser: {
email: process.env.A_EMAIL || '',
password: process.env.A_PASSWORD || '',
email: process.env.ARCHIVE_EMAIL || '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is special, then can we call these vars something else to match their special designation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... but for now it was just what's agreed upon

@@ -68,7 +68,7 @@ test.describe('Profile Page - Basic display tests', () => {
test.describe('Profile Page - Lists', () => {
test.describe.configure({ mode: 'serial' });

test(`Facets appear`, async ({ browser }) => {
test.fixme(`Facets appear`, async ({ browser }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme here - does this test run?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests with fixme annotations will be skipped

await searchPage.collectionFacets.assertSearchFacetGroupCount();
});
});

test(`Facets for "movies" in Media Type facet group`, async ({
test.fixme(`Facets for "movies" in Media Type facet group`, async ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme

@@ -31,8 +32,9 @@ test(`Facets for "movies" in Media Type facet group`, async ({
});
});

test(`Clear facet filters`, async ({ searchPage }) => {
test.fixme(`Clear facet filters`, async ({ searchPage }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme

);
});
});
test.fixme(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme

@@ -120,10 +129,11 @@ test.skip(`Filter for title beginning with "X"`, async ({ searchPage }) => {
});
});

test(`Facets can be selected via "Select filters" modal`, async ({
test.fixme(`Facets can be selected via "Select filters" modal`, async ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixme

@dualcnhq dualcnhq changed the title WEBDEV-6730 fix flaky tests WEBDEV-6730 fix flaky tests - fixmes Jun 26, 2024
@dualcnhq dualcnhq changed the title WEBDEV-6730 fix flaky tests - fixmes WIP: WEBDEV-6730 fix flaky tests - fixmes Jun 26, 2024
@dualcnhq
Copy link
Collaborator Author

closing this for cleanup

@dualcnhq dualcnhq closed this Oct 23, 2024
@dualcnhq dualcnhq deleted the webdev-6730-fix-flaky-tests branch October 23, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants