Enable Flask-CORS by default and update Cantaloupe default #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly set in `ldjsonify` to prevent double headers
|
The test is failing because the example item now has |
|
Test updated to use the same Text item as the v3 test. On the v2 service / archivelabs front, I see Josh has already opened a ticket here: #26 |
|
I've also added a little bit of code to log errors in v2 manifests, the same as we currently have for v3. This should help a little with debugging any other issues. I've left it returning a 404 instead of a 500 afterwards, as this is the current behaviour and I didn't want to break that. |
glenrobson
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues with redirects of v2 images.
The v2 code is still pointing at the old archivelabs service for images, and we should probably change that at some point, but it's a separate issue.
Closes #24