Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Removes PLC1901 - String type comparison rule can be enabled without modifications #10279

Conversation

techy4shri
Copy link
Contributor

@techy4shri techy4shri commented Jan 5, 2025

Part of #10196

[Refactor] Removes PLC1901 - String type comparison rule can be enabled without modifications

Technical

The PLC1901 rule, since unstable and is in "preview" in Ruff; has been removed from the configuration across the repository. This involved updates to the pyproject.toml .

Testing

  1. Verified the repository runs Ruff checks successfully without PLC1901.
  2. Confirmed no errors or warnings are triggered due to PLC1901.

Screenshot

Screenshot 2025-01-05 214738

Stakeholders

@RayBB

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No code changes, as expected.

Now we just need staff to merge.

@RayBB RayBB added Affects: Developers Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. labels Jan 5, 2025
@mekarpeles mekarpeles merged commit 0a2421c into internetarchive:master Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Developers Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants