Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 10390/fix/sanitize single double quote in solr query #10405

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tomrod10
Copy link

Closes #

Technical

Testing

Screenshot

Stakeholders

@tomrod10 tomrod10 changed the title 10390/fix/sanitize single double quote in solr query [WIP] 10390/fix/sanitize single double quote in solr query Jan 30, 2025
@tomrod10
Copy link
Author

The following tests are failing:

  • openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[Spaces after fields]
  • openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[Quotes]
  • openlibrary/plugins/worksearch/schemes/tests/test_works.py::test_process_user_query[LCC: quotes preserved]

@tomrod10
Copy link
Author

tomrod10 commented Jan 30, 2025

Probably will move my test to tests/test_works.py and delete tests/test_SearchScheme.py

@tomrod10 tomrod10 force-pushed the 10390/fix/sanitize-single-double-quote-in-solr-query branch from d77c589 to c8c6638 Compare January 31, 2025 03:09
@tomrod10 tomrod10 force-pushed the 10390/fix/sanitize-single-double-quote-in-solr-query branch from 9d3a2ae to f9ecfe6 Compare January 31, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant