-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added lazy loading to merge books #9312
Added lazy loading to merge books #9312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working.
Though, in my experience is is loading 135 covers vs 167.
So I think maybe there is something with the way Vue renders this that causes many covers to still load. But I think this small improvement should the default anyway.
@cdrini can you review/merge?
Ah interesting ; try adding a |
7586519
to
3117cf6
Compare
@Realmbird in your testing did adding that height effect anything? So this PR has a mild effect but doesn't quite do what we want and it looks like that's not simple to do. |
Ah my bad, I just realized this was for the edition snippet! The edition snippet is working with It's the work covers that need to have These: So you can:
|
@Realmbird do you think you could incorporate drini's feedback? |
@Realmbird still interested in working on this one? |
No sorry forgot to unassign |
Closing this so someone else can work on it. |
Closes #9201
Add lazy loading for covers in works merge tool
Technical
Just adds loading lazy to images for books in merge
Testing
Screenshot
Stakeholders
@cdrini @RayBB