Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add spaces when matching author honorifics #9322

Conversation

scottbarnes
Copy link
Collaborator

@scottbarnes scottbarnes commented May 22, 2024

Matching and stripping honorifics should match honorific + " " and not just honorific. Thanks @hornc for catching this!

Closes #7349
Closes #9321

Fixes cases where names beginning with an honorific (e.g. Dr and Drini would incorrectly match as an honorific).

Technical

This matches and removes honorific + " ", rather than just honorific.

It also incorporates the test from #9321.

Testing

See the updated unit test.

Screenshot

Stakeholders

@cdrini
@hornc

Matching and stripping honorifics should match `honorific + " "` and not
just `honorific`. Thanks @hornc for catching this!
@github-actions github-actions bot added the Priority: 2 Important, as time permits. [managed] label May 22, 2024
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Great catch @hornc !

@cdrini cdrini self-assigned this May 23, 2024
@cdrini cdrini merged commit 57467e1 into internetarchive:master May 23, 2024
4 checks passed
@scottbarnes scottbarnes deleted the fix/add-space-when-matching-author-honorifics branch May 23, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Author Resolution: Don't create duplicate author records for M. <surname> with exact date match
2 participants