Fix: add spaces when matching author honorifics #9322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching and stripping honorifics should match
honorific + " "
and not justhonorific
. Thanks @hornc for catching this!Closes #7349
Closes #9321
Fixes cases where names beginning with an honorific (e.g.
Dr
andDrini
would incorrectly match as an honorific).Technical
This matches and removes
honorific + " "
, rather than justhonorific
.It also incorporates the test from #9321.
Testing
See the updated unit test.
Screenshot
Stakeholders
@cdrini
@hornc