-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added link tracks to all download options #9837
base: master
Are you sure you want to change the base?
Added link tracks to all download options #9837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want different actions for the different download types. Instead of Sidebar, you might want to call that Download
and then after the |
the type
e.g. Download|HTML
@mekarpeles I see what you're saying. How then would we distinguish the |
One option is to have something like Is it most useful to see the total number of downloads? The total number of downloads per type? Either way, so long as we segment/bucket the types we should be able to see what we need -- it just may take 2 queries + manual maths to get the totals we want. I haven't spent much time thinking about the best solution. If we did |
@mekarpeles I agree with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Apologies for the delay @merwhite11 , I forgot to respond to your question on this!
Closes #9782
Adds link tracks to all download options in sidebar so that we can have a baseline reading of patron activity. This reading will then be used to compare the effectiveness of the work-in-progress Read dropdown redesign
.
Testing
Click a download option and ensure that data for SideBar|Download is being recorded in stats.
Stakeholders
@cdrini @mekarpeles
@SivanC -- just letting you know about this one for when you want to compare SideBar|Download with your eventual ReadDropper|Download feature.