-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand author roles #9901
Open
hornc
wants to merge
9
commits into
internetarchive:master
Choose a base branch
from
hornc:author_roles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Expand author roles #9901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9901 +/- ##
==========================================
+ Coverage 17.44% 17.57% +0.12%
==========================================
Files 89 87 -2
Lines 4792 4775 -17
Branches 848 847 -1
==========================================
+ Hits 836 839 +3
+ Misses 3436 3417 -19
+ Partials 520 519 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9844
Technical
Builds on PR #9797 , which should be merged first and this PR rebased for ease of review. #9797 changes very many test files, this PR modifies fewer and should be more contained to address just #9844.Now that #9797 has been merged, I have rebased this and it looks a lot neater, and makes it clear what is changing with contributor roles. Selected abbreviations are expanded from the full list to controlled contributors, and also some common ones from the freeform text of
$e
subfield.Testing
Screenshot
Stakeholders
@tfmorris