Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand author roles #9901

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Expand author roles #9901

wants to merge 9 commits into from

Conversation

hornc
Copy link
Collaborator

@hornc hornc commented Sep 23, 2024

Closes #9844

Technical

Builds on PR #9797 , which should be merged first and this PR rebased for ease of review. #9797 changes very many test files, this PR modifies fewer and should be more contained to address just #9844.

Now that #9797 has been merged, I have rebased this and it looks a lot neater, and makes it clear what is changing with contributor roles. Selected abbreviations are expanded from the full list to controlled contributors, and also some common ones from the freeform text of $e subfield.

Testing

Screenshot

Stakeholders

@tfmorris

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.57%. Comparing base (3025f5d) to head (9a54f2c).
Report is 276 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9901      +/-   ##
==========================================
+ Coverage   17.44%   17.57%   +0.12%     
==========================================
  Files          89       87       -2     
  Lines        4792     4775      -17     
  Branches      848      847       -1     
==========================================
+ Hits          836      839       +3     
+ Misses       3436     3417      -19     
+ Partials      520      519       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hornc hornc marked this pull request as ready for review January 28, 2025 20:20
@cdrini cdrini self-assigned this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Author roles from import source data
3 participants