[uss_qualifier] scd - implicit sub handling: new test case replaces explicit sub with implicit one #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Shastick
changed the title
|
I looked through this PR just now and it seems good generally -- previous review was probably slow because it wasn't yet ready for review since it has conflicts that must be resolved. |
Shastick
force-pushed
the
oir-implicit-replace-explicit
branch
from
8aaa687 to
3afd8e0
Compare
|
Indeed, the SCD PRs have been parked for a while. I refreshed this one. |
BenjaminPelletier
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the
OIRImplicitSubHandlingwith another corner case mentioned here: interuss/dss#1088