[mock_uss] save a notification when telemetry is too sparse #922
+52
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
reviewed
Feb 4, 2025
| @@ -114,6 +115,9 @@ def ridsp_create_test(test_id: str) -> Tuple[str, int]: | |||
|
|
|||
| with db as tx: | |||
| tx.tests[test_id] = record | |||
| for notif in check_and_generate_slow_update_notification(record.flights): | |||
There was a problem hiding this comment.
Shouldn't we keep it consistent between #911 and there ?
There was a problem hiding this comment.
That would make sense. I can add the create_notifications_if_needed function as well with the specifics of the present PR.
| """ | ||
| if not self.telemetry or len(self.telemetry) == 1: | ||
| return None | ||
| if len(self.telemetry) == 1: |
Shastick
force-pushed
the
mock-uss-slow-update-notif
branch
2 times, most recently
from
39c0fa3 to
e6012cc
Compare
|
Aligned with #911 (also did a pass of import optimization with my IDE which explains some of the reordering in the imports) |
the-glu
approved these changes
Feb 4, 2025
Shastick
force-pushed
the
mock-uss-slow-update-notif
branch
4 times, most recently
from
a6a3204 to
89bf5d0
Compare
Shastick
force-pushed
the
mock-uss-slow-update-notif
branch
from
89bf5d0 to
0115f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a building block for the scenario that will cover Net0040, for which notifications must be sent to the operator when the telemetry update rate is insufficient.