[monitorlib/reports] Render newlines in string values #932
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monitorlib houses a Jinja2 macro to render complex dicts as interactive expandable/collapseable elements. This is used in many places, but one important place is representing queries in uss_qualifier reports. When troubleshooting, these queries will often have a stack trace value. But, because Jinja2 renders the string as HTML, newlines are ignored as plain whitespace. This PR addresses that narrow issue by replacing newlines with explicit HTML br elements so stack traces are easier to read.