Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Infinity.jl #95
Add support for Infinity.jl #95
Changes from all commits
617d1e1
4e3ebe5
6b81961
52c528a
f50c266
3564a85
2e1a039
614967f
945757d
dfb91a7
f8d3231
aba26a2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version always kept the
Interval
unit type the same. This could cause the Interval type to change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This becomes the same issue as most of the other issues that cropped up by adding Infinity. If
a
is-∞ .. ∞
andb
is of typeInt
then∞ - b
whereb
is1
becomes anInfExtended{Int64}
type which will error out since T would have beenInterval{Infinite}(...)
. So we end up trying to runconvert(Infinite, InfExtended{Int64})
which is undefined. That being said, maybe that shouldn't be undefined. Converting anInfExtended{Int64})
toInfinite
could potentially work if we check the value to make sure it's not an actual extended valueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That conversion makes sense if the
InfExtended{Int64}
is infiniteThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by adding the conversion: cjdoris/Infinity.jl#7