-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTPS by default and release v1.2.0 #44
base: master
Are you sure you want to change the base?
Conversation
@lnielsen not sure if it should be v2.0.0 actually... One can see it as a "security fix", but on the other hand changing default parameters is breaking API... |
I think the issue with this one is that it's a pretty big "breaking change" to switch to HTTPS URL generation, affecting many other tests e.g. on RDM REST API responses and serialized formats. This means that we'll have to first check if we have upper pins for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
My vote would be to make a ticket in invenio-app-rdm to
- cap idutils in previous versions of invenio-app-rdm and related modules if not already
- then release this
- then integrate the new version of idutils in invenio-app-rdm and related modules
For me: better security / up-to-date schemes trumps potential backward incompatibility / small breakage. And moving sooner rather than later is better. I don't have commit/release rights on this repo anyway though.
No description provided.