Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datamodel: add non-issue fields based on zenodo/datacite #21

Merged
merged 19 commits into from
Oct 30, 2019
Merged

datamodel: add non-issue fields based on zenodo/datacite #21

merged 19 commits into from
Oct 30, 2019

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Oct 25, 2019 •
edited
Loading

Fields:

  • Resource type
  • additional titles
  • additional descriptions
  • dates (Following Zenodo implementation, not DataCite)
  • publication date
  • embargo date
  • language: Using ISO 639-3 (as Zenodo) instead of 639-1 (as DataCite). It's newer and uses 3 letters instead of 2.
  • version
  • rights_list

Validation:

  • All lang attributes be validated and follow the ISO 639-3
  • All enums are validated against their list of values in Marshmallow instead of the JSON Schema. This allows to define configurable control vocabularies.

Addreses part of #18

@ppanero ppanero changed the title WIP: datamodel: add new fields WIP: datamodel: add new fields based on zenodo/datacite Oct 25, 2019
@ppanero ppanero self-assigned this Oct 25, 2019
@ppanero ppanero force-pushed the zenodo branch 6 times, most recently from 2188524 to 3cb2349 Compare October 25, 2019 11:27
@ppanero ppanero changed the title WIP: datamodel: add new fields based on zenodo/datacite datamodel: add non-issue fields based on zenodo/datacite Oct 29, 2019
@ppanero ppanero requested a review from fenekku October 29, 2019 14:08
@ppanero ppanero mentioned this pull request Oct 29, 2019
Closed
17 tasks
fenekku
fenekku reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was huge :) . Assume the non-minor marked comments are "normal". The main thing is getting the jsonschema right. The mappings and marshmallow schemas follow well from that.

invenio_rdm_records/data/objecttypes.json Show resolved Hide resolved
tests/unit/test_schemas_json_load.py Show resolved Hide resolved
invenio_rdm_records/jsonschemas/records/record-v1.0.0.json Show resolved Hide resolved
invenio_rdm_records/jsonschemas/records/record-v1.0.0.json Show resolved Hide resolved
invenio_rdm_records/jsonschemas/records/record-v1.0.0.json Show resolved Hide resolved
invenio_rdm_records/marshmallow/json.py Outdated Show resolved Hide resolved
invenio_rdm_records/marshmallow/json.py Show resolved Hide resolved
invenio_rdm_records/marshmallow/utils.py Show resolved Hide resolved
invenio_rdm_records/models.py Outdated Show resolved Hide resolved
invenio_rdm_records/models.py Show resolved Hide resolved
@ppanero ppanero mentioned this pull request Oct 30, 2019
Closed
Pablo Panero added 2 commits October 30, 2019 15:13
schema: improvements and fixes on embargo_date, recid and resource_type
bfb975d 
- Remove OpenAire related subtypes
- Make resource_type subtype required
- Fix typo in tests description
- Minor style improvements
mappings: refactor from object to nested
21af85c
fenekku
fenekku approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future Approved

@ppanero ppanero mentioned this pull request Oct 30, 2019
Closed
35 tasks
tmorrell
tmorrell approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. I assume the enums will come later.

invenio_rdm_records/jsonschemas/records/record-v1.0.0.json Show resolved Hide resolved
invenio_rdm_records/jsonschemas/records/record-v1.0.0.json Show resolved Hide resolved
@fenekku fenekku merged commit 8fea2cc into inveniosoftware:master Oct 30, 2019
@fenekku fenekku mentioned this pull request Oct 30, 2019
Closed
@ppanero ppanero deleted the zenodo branch February 20, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenekku fenekku fenekku approved these changes

@tmorrell tmorrell tmorrell approved these changes

Assignees

@ppanero ppanero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppanero @fenekku @tmorrell