Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivateMessages: Fix RuntimeWarning for naive datetime #1382

Merged
merged 1 commit into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions inyoka/portal/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import gzip
import hashlib
import os
from datetime import datetime, timedelta
from datetime import timedelta

from django.conf import settings
from django.contrib.contenttypes.fields import GenericForeignKey
Expand All @@ -20,6 +20,7 @@
from django.core.validators import RegexValidator
from django.db import models, transaction
from django.db.models import Count
from django.utils import timezone as dj_timezone
from django.utils.functional import cached_property
from django.utils.translation import gettext_lazy

Expand Down Expand Up @@ -215,13 +216,13 @@ def clean_private_message_folders(cls):

privmsgs_trash = PrivateMessageEntry.objects.filter(
folder=trash,
message__pub_date__lte=datetime.now() - timedelta(
message__pub_date__lte=dj_timezone.now() - timedelta(
days=settings.PRIVATE_MESSAGE_TRASH_DURATION),
).exclude(user__groups__name__exact=settings.INYOKA_TEAM_GROUP_NAME)

privmsgs_inbox_sent = PrivateMessageEntry.objects.filter(
folder__in=[inbox, sent],
message__pub_date__lte=datetime.now() - timedelta(
message__pub_date__lte=dj_timezone.now() - timedelta(
days=settings.PRIVATE_MESSAGE_INBOX_SENT_DURATION),
).exclude(user__groups__name__exact=settings.INYOKA_TEAM_GROUP_NAME)

Expand Down
4 changes: 2 additions & 2 deletions tests/apps/portal/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
:license: BSD, see LICENSE for more details.
"""
import gzip
from datetime import datetime, timedelta
from datetime import timedelta
from os import path

from django.conf import settings
Expand Down Expand Up @@ -191,7 +191,7 @@ def setUp(self):
'other_user',
'[email protected]',
'pwd', False)
pm = PrivateMessage(author=user, subject="Expired message", pub_date=datetime.now() -
pm = PrivateMessage(author=user, subject="Expired message", pub_date=dj_timezone.now() -
timedelta(days=settings.PRIVATE_MESSAGE_INBOX_SENT_DURATION))
pm.send([self.other_user])

Expand Down
6 changes: 3 additions & 3 deletions tests/apps/portal/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
from django.http import Http404
from django.test import Client, RequestFactory
from django.test.utils import override_settings
from django.utils import timezone as dj_timezone
from django.utils import translation
from django.utils.timezone import now
from django.utils.translation import gettext as _
from freezegun import freeze_time
from guardian.shortcuts import assign_perm
Expand Down Expand Up @@ -692,13 +692,13 @@ def test_access(self):
def test_delete_many(self):
user2 = User.objects.register_user('user2', '[email protected]', 'user', False)
pm1 = PrivateMessage.objects.create(author=user2, subject='Subject',
text='Text', pub_date=now())
text='Text', pub_date=dj_timezone.now())
PrivateMessageEntry.objects.create(message=pm1, user=user2,
read=False, folder=PRIVMSG_FOLDERS['sent'][0])
pme1 = PrivateMessageEntry.objects.create(message=pm1, user=self.user,
read=False, folder=PRIVMSG_FOLDERS['inbox'][0])
pm2 = PrivateMessage.objects.create(author=user2, subject='Subject',
text='Text', pub_date=now())
text='Text', pub_date=dj_timezone.now())
PrivateMessageEntry.objects.create(message=pm2, user=user2,
read=False, folder=PRIVMSG_FOLDERS['sent'][0])
pme2 = PrivateMessageEntry.objects.create(message=pm2, user=self.user,
Expand Down
Loading