Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update robots.txt #441

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

KaiserBarbarossa
Copy link
Member

This pull request removes no more needed entrys in robots.txt file.

inyoka_theme_ubuntuusers/static/robots.txt Outdated Show resolved Hide resolved
Disallow: /_image?
Disallow: /Benutzer/
Disallow: /users/
Disallow: /*?flavour=mobile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the URLs do no switch to a mobile version any more, they are still valid (f.e. https://ubuntuusers.de/?flavour=mobile displays the same content like https://ubuntuusers.de/ with HTTP 200). So a possible drawback could be duplicate URLs in the search index, because links still use this variant or are still in the google index etc. Thus, i would avoid this removal. Any other opinions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that’s probably right. However fixed now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the flavour parameter is deprecated, could we instead use redirects? Then search engines and alike would take notice and not crawl them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO that's hard to do within Inyoka, as this potentially affects every view (and also 'only' old intances). I dont know whether the used proxy has the ability to 'remove' all flavour HTTP-Parameter with a 301.

@@ -1,16 +1,6 @@
User-agent: *
Crawl-delay: 10
Disallow: /search
Disallow: /_image?
Disallow: /Benutzer/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If /Benutzer/ is blocked for bots, shouldn't /user/ be blocked too?

Copy link
Member

@chris34 chris34 Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anonymous users see at /user/-URLs a login page, so i dont see really a benefit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But they see a login page at /Benutzer/ too. So wouldn’t it be consequent also to remove that line and the /users/ one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid Point. However, to resolve this i would suggest another thing: Return not HTTP 200 on login pages, instead 403 (or 404, if we want to hide the page's existence).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the user names and links to it's profiles are known, we don't need to and can hide the pages' existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants