Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create INCOIS dataset template #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

create INCOIS dataset template #14

wants to merge 4 commits into from

Conversation

jmckenna
Copy link
Collaborator

@jmckenna jmckenna commented Apr 15, 2024

  • this issue will track the development of a dataset JSON-LD template to provide to the INCOIS team
  • the current pull request version is just a nicely formatted version of this sample record's JSON-LD as-is: https://incois.gov.in/essdp/ViewMetadata?fileid=524fd72e-6b2f-4025-94ea-361dce0e9165
  • possible sections to improve/correct:
    • remove extra comma in PostalAddress (with that change, the template validates)
    • review Keywords syntax with DefinedTerm
    • review creator property (with sub-creator property)
      • is that the correct syntax?

related to iodepo/odis-arch#396

cc @pbuttigieg

@jmckenna jmckenna changed the title initial INCOIS dataset template create INCOIS dataset template Apr 15, 2024
@jmckenna jmckenna marked this pull request as draft April 23, 2024 12:59
@pbuttigieg
Copy link
Collaborator

pbuttigieg commented Jun 1, 2024

@jmckenna this was helpful: http://blog.schema.org/2014/06/introducing-role.html

It's a little unusual to me, but Role is an intervening Type between a relationship and other entities, and the repetition of the original relation (in this case creator) seems valid. I'd improve it by adding starting and ending dates for the role, but these are optional.

SmartSelect_20240601_094658_Chrome.png

    "creator": [ 
         { 
             "@type": "Role", 
             "roleName": "PrincipalInvestigator", 
             "creator": { 
                 "@type": "Person", 
                 "name": "Mr. Hashim Manjebrayakath", 
                 "email": "anil [ at ] ncaor.gov.in", 
                 "telephone": "+91-832-2525513", 
                 "affiliation": { 
                     "@type": "Organization", 
                     "name": "National Centre for Polar and Ocean Research (NCPOR)" 
                 }, 
                 "address": { 
                     "@type": "PostalAddress", 
                     "addressLocality": "Vasco-da-Gama", 
                     "addressRegion": "Goa", 
                     "postalCode": "403804", 
                     "addressCountry": "IND" 
                 } 
             } 
         } 
     ]

@jmckenna
Copy link
Collaborator Author

@pbuttigieg my earlier question here to you about Keywords with DefinedTerm is now critical as I tested bringing the INCOIS records into Solr/front-end search, and all of that code does not support keywords with DefinedTerms :(
example:

  "keywords": [
    {
      "@type": "DefinedTerm",
      "name": "Aerosol Forward Scatter",
      "inDefinedTermSet": "https://gcmd.earthdata.nasa.gov/kms/concepts/concept_scheme/sciencekeywords"
    },
    {
      "@type": "DefinedTerm",
      "name": "Aerosol Extinction",
      "inDefinedTermSet": "https://gcmd.earthdata.nasa.gov/kms/concepts/concept_scheme/sciencekeywords"
    },
    {
      "@type": "DefinedTerm",
      "name": "Aerosol Particle Properties",
      "inDefinedTermSet": "https://gcmd.earthdata.nasa.gov/kms/concepts/concept_scheme/sciencekeywords"
    },
    "Mahabaleshwar(1792N",
    "High Altitude Cloud Physics Laboratory"
  ],

INCOIS team is VERY fast to adapt to our recommended changes. So do we: 1) adapt all of our code to handle DefinedTerms in Keywords, or 2) ask INCOIS to change to ______ ?

Need your feedback here @pbuttigieg

(related to iodepo/odis-arch#396 )

@jmckenna jmckenna marked this pull request as ready for review November 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants