Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 create localcontext examples #23

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

pbuttigieg
Copy link
Collaborator

Creating content for #11

@pbuttigieg pbuttigieg added the enhancement New feature or request label Jun 26, 2024
@pbuttigieg pbuttigieg self-assigned this Jun 26, 2024
@pbuttigieg pbuttigieg linked an issue Jun 26, 2024 that may be closed by this pull request
@jmckenna
Copy link
Collaborator

cc @arojas1

Copy link

@arojas1 arojas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and suggested changes for the Notices graph. Still need to review the Labels and Project graphs.

@@ -0,0 +1,55 @@
{
"@type": "CreativeWork",
"identifier": "{Notice ID}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example of identifier would be https://localcontexts.org/notice/open-to-collaborate/ URL would be based on the Notice added. This is for now as this is where we have our template information for the Notices, what would be a good alternative for this?

"@value": "{Notice Text}"
}
],
"url": "{NOTICE_PAGE_URL}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as URL above

"image": [
{
"@type": "ImageObject",
"url": "{ICON_IMG}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder URL added here, actual URL will be available via the API calls

},
{
"@type": "ImageObject",
"url": "{ICON_SVG}",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as img url here

Comment on lines 45 to 53
"sdDatePublished": {"@type": "https://schema.org/Date"},
"sdLicense": [
{"@type": "https://schema.org/CreativeWork"},
{"@type": "https://schema.org/URL"}
],
"sdPublisher": [
{"@type": "https://schema.org/Organization"},
{"@type": "https://schema.org/Person"}
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbuttigieg I can't remember what we decided for this but is this meant to be the date the Project was created (and thus the Notices published against the dataset) or is this meant to be for the person creating this metadata to indicate when their dataset, creativework, etc. was created? Or is it meant to be when Local Contexts created and published the Notices themselves, since they aren't being changed?

],
"author": {
"@type": "Organization",
"identifier": "https://oceanexpert.org/institution/xxxxxxx",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on getting us an identifier to add here. Will update when we have it

{"@type": "https://schema.org/Organization"},
{"@type": "https://schema.org/Person"}
],
"creditText": "text: recommended citation"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this would go here but we have this text that we use "All Labels and Notices Icons and Template Texts © 2010 - 2024 Local Contexts. All Rights Reserved." (the year would have to be updated yearly or can we just have 2010 as the start and have it extend endlessly?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arojas1 that text sounds like a copyrightNotice, I have added it into this pull request.

@jmckenna
Copy link
Collaborator

jmckenna commented Oct 16, 2024

@arojas1 I have made several updates inside this PR as the structure of the odis-in repo has changed since this initial PR was made - it should now merge nicely, when ready. (you'll have to pull in the changes locally in your branch). Thanks for all of your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create LocalContexts Examples
3 participants