Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document release process #88

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Document release process #88

merged 3 commits into from
Jun 28, 2024

Conversation

StefMa
Copy link
Collaborator

@StefMa StefMa commented Jun 19, 2024

fixes #47

@StefMa StefMa requested review from rsjethani and rsj-ioki June 19, 2024 11:52
rsjethani
rsjethani reviewed Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@rsjethani rsjethani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the target audience of this information is a fellow contributor and not the module consumer. Hence it should be in CONTRIBUTING.md file.

@StefMa
Copy link
Collaborator Author

StefMa commented Jun 23, 2024 •
edited
Loading

I am fine with that 🙃.
But what do you think about a RELEASE.md file? 🤔

@rsjethani
Copy link
Collaborator

I am fine with that 🙃.
But what do you think about a RELEASE.md file? 🤔

Yes sounds even better 👍

@StefMa StefMa requested a review from rsjethani June 26, 2024 07:37
rsjethani
rsjethani approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@rsjethani rsjethani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this

@StefMa StefMa merged commit bc87758 into main Jun 28, 2024
4 checks passed
@StefMa StefMa deleted the release-process-doc branch June 28, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsjethani rsjethani rsjethani approved these changes

@rsj-ioki rsj-ioki Awaiting requested review from rsj-ioki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document release process
2 participants
@StefMa @rsjethani