exposition: impose row group limit for parquet #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove internal buffering from the ParquetWriter and instead write single snapshots to the ArrowWriter which buffers data internally until the row group size limit is reached. Set the row group limit for the ArrowWriter from the specified batch size in the ParquetOptions. Finally, reduce the default row group size from 1M to 50K.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Does this solve https://github.com/iopsystems/systemslab/issues/1571? If so that would be quite nice |
|
I don't know if it fixes it entirely, but it should reduce the footprint substantially (for instance, I'm able to tune stuff down to a memory overhead of < 1GB). |
brayniac
reviewed
May 28, 2024
| @@ -14,7 +12,7 @@ use parquet::format::{FileMetaData, KeyValue}; | |||
|
|
|||
| use crate::snapshot::{HashedSnapshot, Snapshot}; | |||
|
|
|||
| const DEFAULT_MAX_BATCH_SIZE: usize = 1024 * 1024; | |||
| const DEFAULT_MAX_BATCH_SIZE: usize = 50_000; | |||
There was a problem hiding this comment.
Is it worth leaving a comment with the rationale for this size?
brayniac
reviewed
May 28, 2024
brayniac
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove internal buffering from the ParquetWriter and instead
write single snapshots to the ArrowWriter which buffers data
internally until the row group size limit is reached. Set
the row group limit for the ArrowWriter from the specified
batch size in the ParquetOptions. Finally, reduce the default
row group size from 1M to 50K.