Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update parquet and arrow to 53.0.0 #36

Merged
merged 2 commits into from
Sep 18, 2024
Merged

deps: update parquet and arrow to 53.0.0 #36

merged 2 commits into from
Sep 18, 2024

Conversation

mihirn
Copy link
Contributor

@mihirn mihirn commented Sep 17, 2024

No description provided.

Copy link
Contributor

@swlynch99 swlynch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does metriken-exposition expose either of these publically? If so this should be a major version bump, if not then this is fine as-is and LGTM.

@mihirn
Copy link
Contributor Author

mihirn commented Sep 17, 2024

Do you mean re-exposed via pub use? If so, no, though happy to do a major bump just to be safer since the versioning with polars is not always very good.

@swlynch99
Copy link
Contributor

swlynch99 commented Sep 17, 2024

It's not so much pub use as whether it is exposed as part of the public API, even if not re-exported.

Instead of just bumping the major version you can use cargo semver-checks to verify that it's not a breaking change :)

See https://github.com/obi1kenobi/cargo-semver-checks

@mihirn
Copy link
Contributor Author

mihirn commented Sep 17, 2024

semver-checks seems happy enough with it at 0.9.2, but I'm still tempted to keep this as a major version, because having multiple versions of arrow/parquet/polars results in badness, and perhaps requiring things to opt into upgrades is nice.

Not a terribly strong opinion though...

@swlynch99
Copy link
Contributor

If it is not part of the public API then that's not an issue, you just end up with multiple versions being compiled in. But tbh it really doesn't matter that much, feel free to go for the major version bump if you think it is appropriate.

@mihirn mihirn merged commit 2e4211f into main Sep 18, 2024
9 checks passed
@mihirn mihirn deleted the msn/deps branch September 18, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants