-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockdao] add analyser indexer for AV3 #4352
base: master
Are you sure you want to change the base?
Conversation
Please retry analysis of this Pull-Request directly on SonarCloud |
@@ -54,6 +55,61 @@ func NewInMemTestServer(cfg config.Config) (*Server, error) { // notest | |||
return newServer(cfg, true) | |||
} | |||
|
|||
func NewServerWithAnalyserIndexers(cfg config.Config, analyserIndexers []blockdao.BlockIndexer) (*Server, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many redundant codes, try to combine the common codes
rpcStats := nodestats.NewAPILocalStats() | ||
builder.SetRPCStats(rpcStats) | ||
|
||
cs, err = builder.BuildWithAnalyserIndexers(analyserIndexers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use builder.SetIndexers(indexers)
instead
@@ -56,6 +57,8 @@ type ( | |||
blockDAO struct { | |||
blockStore BlockDAO | |||
indexers []BlockIndexer | |||
// add analyser indexer | |||
analyserIndexers []BlockIndexer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reasons to split indexes into two parts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many analyserIndexers, and they will not block the chain server from starting, nor will they block each other. so analyserIndexers asynchronously catch up with the tipHeight
code is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- extra indexers are not analyzer specific, we can delete
analyser
from all the parameter or function names - the complexity of the extra indexers should not be implemented in iotex-core
- in builder.go, add a function SetExtraIndexer(indexer BlockIndexer) ...
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: