Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockdao] add analyser indexer for AV3 #4352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[blockdao] add analyser indexer for AV3 #4352

wants to merge 2 commits into from

Conversation

hunshenshi
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@@ -54,6 +55,61 @@ func NewInMemTestServer(cfg config.Config) (*Server, error) { // notest
return newServer(cfg, true)
}

func NewServerWithAnalyserIndexers(cfg config.Config, analyserIndexers []blockdao.BlockIndexer) (*Server, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many redundant codes, try to combine the common codes

rpcStats := nodestats.NewAPILocalStats()
builder.SetRPCStats(rpcStats)

cs, err = builder.BuildWithAnalyserIndexers(analyserIndexers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use builder.SetIndexers(indexers) instead

@@ -56,6 +57,8 @@ type (
blockDAO struct {
blockStore BlockDAO
indexers []BlockIndexer
// add analyser indexer
analyserIndexers []BlockIndexer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reasons to split indexes into two parts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many analyserIndexers, and they will not block the chain server from starting, nor will they block each other. so analyserIndexers asynchronously catch up with the tipHeight
code is here

Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. extra indexers are not analyzer specific, we can delete analyser from all the parameter or function names
  2. the complexity of the extra indexers should not be implemented in iotex-core
  3. in builder.go, add a function SetExtraIndexer(indexer BlockIndexer) ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants