Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECMP hash table update for keys used #130

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

5abeel
Copy link
Collaborator

@5abeel 5abeel commented May 22, 2024

The P4Compiler has changed the generated key names in p4info.txt for ECMP hash tables (the table types have changed in LNWv3 to WCM table). Due to the change, retrieving this table was resulting in an infrap4d crash.

Generated table keys are shown below:

tables {
  preamble {
    id: 49661222
    name: "linux_networking_control.ecmp_hash_table"
    alias: "ecmp_hash_table"
  }
  match_fields {
    id: 1
    name: "flex" ## --> this should be matched in our code
    bitwidth: 16
    match_type: TERNARY
  }
  match_fields {
    id: 2
    name: "hash" ## --> this should be matched in our code
    bitwidth: 3
    match_type: TERNARY
  }

Also, in LNWv3, we do not have the zero_padding, so commenting the section out for ecmp_hash_table

5abeel added 2 commits May 22, 2024 07:34
Copy link
Contributor

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vsureshkumarp vsureshkumarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@5abeel 5abeel merged commit 8c50de5 into main May 22, 2024
4 checks passed
@5abeel 5abeel deleted the ecmp_hash_table_update branch May 22, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants