Extract ES2K NEIGHBOR_MOD_TABLE definitions (3/5) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ffoulkes
commented
May 29, 2024
ffoulkes
commented
- Extracted the LNWv3 NEIGHBOR_MOD_TABLE definitions into a separate header file.
- Extracted the LNWv3 NEIGHBOR_MOD_TABLE definitions into a separate header file. Signed-off-by: Derek Foster <[email protected]>
ffoulkes
requested review from
5abeel,
n-sandeep and
vsureshkumarp
as code owners
One comment here - looks like the PR is only addressing LNWv2 - typo in the main comment? |
You're right. the NEIGHBOR_MOD_TABLE is specific to LNWv2. There's a typo in the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.