Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better self-service commands for DHT providing #815

Merged
merged 7 commits into from
Jan 31, 2025

Conversation

gsergey418alt
Copy link
Contributor

Add LastRun and NextRun stats. Fixes Kubo issue #10265.

@gsergey418alt gsergey418alt requested a review from a team as a code owner January 27, 2025 13:51
Copy link

welcome bot commented Jan 27, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@gsergey418alt gsergey418alt changed the title Feat: Better self-service commands for DHT providing [skip changelog] feat: Better self-service commands for DHT providing [skip changelog] Jan 27, 2025
@gsergey418alt gsergey418alt changed the title feat: Better self-service commands for DHT providing [skip changelog] feat: Better self-service commands for DHT providing Jan 28, 2025
@guillaumemichel guillaumemichel self-assigned this Jan 28, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.45%. Comparing base (3c70cf3) to head (01f1a83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
provider/reprovider.go 33.33% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   60.46%   60.45%   -0.02%     
==========================================
  Files         244      244              
  Lines       31097    31100       +3     
==========================================
- Hits        18803    18800       -3     
- Misses      10616    10622       +6     
  Partials     1678     1678              
Files with missing lines Coverage Δ
provider/reprovider.go 68.32% <33.33%> (-0.32%) ⬇️

... and 10 files with indirect coverage changes

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but waiting on ipfs/kubo#10677 CI to be green before merging.

CHANGELOG.md Outdated Show resolved Hide resolved
@gsergey418alt
Copy link
Contributor Author

For the CI to pass, it needs this PR as a dependency. It won't build without the ReproviderStats structure containing the right values. You would have to merge this one first.

@gsergey418alt
Copy link
Contributor Author

I could update the go.mod file of the kubo PR to point to the right branch on my fork, but you'd have to undo it before merging.

@gsergey418alt
Copy link
Contributor Author

Just did that, you can approve the workflows.

@guillaumemichel
Copy link
Contributor

I could update the go.mod file of the kubo PR to point to the right branch on my fork, but you'd have to undo it before merging.

Yes, I did it in ipfs/kubo@439f2d4

@guillaumemichel
Copy link
Contributor

@gsergey418alt I updated the logic, let me know if it works for you

@gsergey418alt
Copy link
Contributor Author

@guillaumemichel Yeah, it's probably a better idea to compute NextRun when displaying the stats.

@guillaumemichel guillaumemichel merged commit 5c158ec into ipfs:main Jan 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants