-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Better self-service commands for DHT providing #815
feat: Better self-service commands for DHT providing #815
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #815 +/- ##
==========================================
- Coverage 60.46% 60.45% -0.02%
==========================================
Files 244 244
Lines 31097 31100 +3
==========================================
- Hits 18803 18800 -3
- Misses 10616 10622 +6
Partials 1678 1678
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but waiting on ipfs/kubo#10677 CI to be green before merging.
For the CI to pass, it needs this PR as a dependency. It won't build without the ReproviderStats structure containing the right values. You would have to merge this one first. |
I could update the go.mod file of the kubo PR to point to the right branch on my fork, but you'd have to undo it before merging. |
Just did that, you can approve the workflows. |
Yes, I did it in ipfs/kubo@439f2d4 |
e8239cc
to
4e2d874
Compare
@gsergey418alt I updated the logic, let me know if it works for you |
@guillaumemichel Yeah, it's probably a better idea to compute NextRun when displaying the stats. |
Add LastRun and NextRun stats. Fixes Kubo issue #10265.