improve(p2p-listener): ensure safe type assertion in stream handling #10690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitsrc <[email protected]>
gitsrc
changed the title
lidel
requested changes
Feb 4, 2025
Comment on lines
-55
to
-56
| if l != nil { | ||
| go l.(*remoteListener).handleStream(stream) |
There was a problem hiding this comment.
triage notes: @gitsrc when was this causing panic? fixing the underlying issue sounds like the right way, we dont want to silence the error
There was a problem hiding this comment.
Thanks for the note! To clarify, no panic has actually occurred. While reading and learning this part of the code, I felt it could use some additional robustness to prevent potential issues.
There was a problem hiding this comment.
Hm.. for sure we don't want to hide the problem if it ever occurs, as that will be painful to debug.
I'm leaning towards closing this PR unless convinced there is net value add in doing this (panic repro or description of why its ok to ignore panic).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remoteListeneris valid[skip changelog]