Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#625: flatpak lint #648

Merged
merged 12 commits into from
Jan 1, 2025
Merged

#625: flatpak lint #648

merged 12 commits into from
Jan 1, 2025

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Jan 1, 2025

Summary by Sourcery

Update the Flatpak metadata, fix icon name, add developer info, include screenshots, and switch to using a Git source for the build.

Build:

  • Switch to building from a Git source instead of a local directory.

Documentation:

  • Add screenshots to the appdata.

Chores:

  • Update the appdata.

@lidaobing lidaobing self-assigned this Jan 1, 2025
Copy link

sourcery-ai bot commented Jan 1, 2025

Reviewer's Guide by Sourcery

This pull request updates the Flatpak manifest to fix linting issues and updates the build system to use the latest iptux source code.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the application metadata in the metainfo file.
  • Added developer information.
  • Added screenshots.
  • Updated the icon type.
  • Added content rating metadata.
share/metainfo/io.github.iptux_src.iptux.metainfo.xml
Updated the Flatpak build configuration to fetch the latest iptux source code from the official Git repository.
  • Changed the source type from 'dir' to 'git'.
  • Added the Git URL and commit hash for the iptux repository.
scripts/flatpak/io.github.iptux_src.iptux.yml
Removed the installation of the appdata directory.
  • Removed the line that installs the 'appdata' directory.
share/meson.build

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lidaobing lidaobing merged commit 0b95385 into master Jan 1, 2025
12 of 13 checks passed
@lidaobing lidaobing deleted the bf_625_flatpak branch January 1, 2025 23:48
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (8e49691) to head (5b7685f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   52.47%   52.47%           
=======================================
  Files          64       64           
  Lines        8557     8557           
=======================================
  Hits         4490     4490           
  Misses       4067     4067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant