-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable LTO(Link Time Optimization) for UI test #652
Conversation
Reviewer's Guide by SourceryThis pull request disables LTO (Link Time Optimization) for the UI test executable. This change was made to address issue #651. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lidaobing - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a brief explanation in the commit message about why LTO needs to be disabled for UI tests, even though the issue is referenced
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
- Coverage 52.48% 52.47% -0.02%
==========================================
Files 64 64
Lines 8557 8557
==========================================
- Hits 4491 4490 -1
- Misses 4066 4067 +1 ☔ View full report in Codecov by Sentry. |
/close #651
Summary by Sourcery
Bug Fixes: