Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable LTO(Link Time Optimization) for UI test #652

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

lidaobing
Copy link
Member

@lidaobing lidaobing commented Jan 26, 2025

/close #651

Summary by Sourcery

Bug Fixes:

  • Disabled link time optimization (LTO) for UI tests to resolve a test failure.

@lidaobing lidaobing linked an issue Jan 26, 2025 that may be closed by this pull request
Copy link

sourcery-ai bot commented Jan 26, 2025

Reviewer's Guide by Sourcery

This pull request disables LTO (Link Time Optimization) for the UI test executable. This change was made to address issue #651.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Disabled LTO for the UI test executable.
  • Added '-fno-lto' to cpp_args.
  • Added '-fno-lto' to link_args.
src/iptux/meson.build

Assessment against linked issues

Issue Objective Addressed Explanation
#651 Fix build failure when Link Time Optimization (LTO) is enabled for UI tests
#651 Resolve test failures caused by LTO compilation

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lidaobing - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief explanation in the commit message about why LTO needs to be disabled for UI tests, even though the issue is referenced
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Test Results

66 tests  ±0   66 ✅ ±0   2s ⏱️ -2s
32 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2455caa. ± Comparison against base commit 2462921.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (2462921) to head (2455caa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   52.48%   52.47%   -0.02%     
==========================================
  Files          64       64              
  Lines        8557     8557              
==========================================
- Hits         4491     4490       -1     
- Misses       4066     4067       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lidaobing lidaobing merged commit 3b87307 into master Jan 26, 2025
11 of 16 checks passed
@lidaobing lidaobing deleted the 651-lto branch January 26, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iptux v0.9.3 build failure when LTO is enabled
1 participant