Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low health beeping #13

Closed

Conversation

danaYatsuta
Copy link

Low health will now only cause 3 beeps instead of infinity.

@danaYatsuta danaYatsuta changed the title beep beep be--[smosh voice] SHUT UP Fix low health beeping Feb 2, 2025
@iriv24
Copy link
Owner

iriv24 commented Feb 2, 2025

how did you find how to do this one? mostly asking because its just a midi and i cant really review it before merging lmao

@kittenchilly
Copy link

@danaYatsuta
Copy link
Author

danaYatsuta commented Feb 3, 2025

https://github.com/rh-hideout/pokeemerald-expansion/blob/9c532997b690f37b22376d19079937ae35dada4f/sound/songs/midi/se_low_health_short.mid

You should probably use this midi since the one on TAAR has a pitch issue

@kittenchilly Thank you, I haven't noticed the pitch issue! Updated the PR to use that midi file.

@danaYatsuta danaYatsuta closed this by deleting the head repository Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants