now with more moore #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've integrated this into my PR and started adding other commits there. |
|
very nice. thanks. |
alanking
reviewed
Jun 20, 2024
| if not objects: | ||
| return None, message | ||
|
|
||
| # TODO: replace |
| log("%s:%s" % (key, value)) | ||
|
|
||
| # call the main script - returns a status message | ||
| message = send_to_irods(conn, script_params) |
There was a problem hiding this comment.
Just noting that message is a tuple, but the names in send_to_irods would indicate that the item in position 1 (i.e. the second item) is the "message" piece. Is this on purpose?
Comment on lines
+177
to
+178
| message = "transferred" | ||
| return message |
There was a problem hiding this comment.
Consider returning images, message? The other return points return tuples.
Also, do we want to append "transferred" to the message? It looks like the message is started on L154...
Despite many hard-codings custom to this sandbox (user, password, etc.),
this script permits running the `omero transfer pack` command to create
an archive for the chosen images and send them to iRODS.
Simple reproducer:
```
cd server
touch a.fake
IMAGE=$(omero import a.fake)
omero script upload --official Send_to_iRODS.py
omero script launch /Send_to_iRODS.py IDs=${IMAGE##Image:}
````
A file named `transfer.tar` will now exist in the iRODS zone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one commit atop #29