Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#246] Use configured default resource for uploads #248

Merged
merged 1 commit into from
Jul 13, 2021
Merged

[#246] Use configured default resource for uploads #248

merged 1 commit into from
Jul 13, 2021

Conversation

korydraughn
Copy link
Contributor

No description provided.

@trel
Copy link
Contributor

trel commented Jul 7, 2021

this seems good upon inspection. want to wait for feedback from peter?

@korydraughn
Copy link
Contributor Author

i don't mind waiting on feedback from peter.

@trel
Copy link
Contributor

trel commented Jul 8, 2021

ping @peterverraedt

@korydraughn korydraughn force-pushed the 246 branch 2 times, most recently from 8de471a to 509fb3b Compare July 8, 2021 17:52
peterverraedt
peterverraedt approved these changes Jul 13, 2021
View reviewed changes
Copy link

@peterverraedt peterverraedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the issue

@korydraughn korydraughn marked this pull request as ready for review July 13, 2021 14:52
@korydraughn
Copy link
Contributor Author

added #

@trel trel merged commit 5dfdc94 into irods-contrib:master Jul 13, 2021
@korydraughn korydraughn deleted the 246 branch July 13, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trel trel trel left review comments

@peterverraedt peterverraedt peterverraedt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korydraughn @trel @peterverraedt