stores identity in multisig account value #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
force-pushed
the
feat/hughy/migrate-encrypted-wallet
branch
3 times, most recently
from
49815b7 to
19637d8
Compare
hughy
force-pushed
the
feat/hughy/migrate-encrypted-wallet
branch
from
19637d8 to
818d105
Compare
Base automatically changed from
feat/hughy/migrate-encrypted-wallet
to
staging
November 26, 2024 19:00
hughy
force-pushed
the
feat/hughy/multisig-keys-identity
branch
3 times, most recently
from
8c107ff to
c178808
Compare
hughy
force-pushed
the
feat/hughy/multisig-keys-identity
branch
from
c178808 to
1fb485b
Compare
updates the MultisigKeys interface to store the multisig account identity in the account value adds a migration, 034, that derives the account identity from the account secret already stored in the account updates importAccount to derive identity from secret at time of import. deriving the identity instead of using the identity included in the import maintains backwards compatibility
hughy
force-pushed
the
feat/hughy/multisig-keys-identity
branch
from
1fb485b to
b7253e0
Compare
jowparks
reviewed
Jan 21, 2025
jowparks
reviewed
Jan 21, 2025
jowparks
reviewed
Jan 21, 2025
ironfish/src/migrations/data/033-multisig-keys-identity/new/accountValue.ts
Show resolved
Hide resolved
jowparks
reviewed
Jan 21, 2025
jowparks
approved these changes
Jan 21, 2025
NullSoldier
reviewed
Jan 21, 2025
NullSoldier
reviewed
Jan 21, 2025
updates initialization of multisigKeys from accountValue to occur as soon as accountValue.multisigKeys is checked updates multisigKeys using its own value instead of accountValue.multisigKeys. preserves any updates to multisigKeys after initialization
accommodates future additions of other multisigKeys types
|
I tested this migration by creating a coordinator, 3 participants, and 1 normal single signer account. I ran the migration and checked the data, I also encrypted my wallet and checked the migrations again. All cases seem to work. I'm going to LGTM this PR but one more person should manually test the migrations. |
NullSoldier
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updates the MultisigKeys interface to store the multisig account identity in the account value
adds a migration, 033, that derives the account identity from the account secret already stored in the account
updates importAccount to derive identity from secret at time of import. deriving the identity instead of using the identity included in the import maintains backwards compatibility
Closes IFL-3118
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.